limit the max value of cluster.max_shards_per_node to avoid int overflow #14155
Conversation
kkewwei
requested review from
Bukhtawar,
CEHENKLE,
Rishikesh1159,
VachaShah,
anasalkouz,
andrross,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
tlfeng
as code owners
kkewwei
force-pushed
the
pr_13907
branch
2 times, most recently
from
f73f384 to
730b329
Compare
|
❌ Gradle check result for f73f384: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 730b329: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 3616d55: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
@shwetathareja leaving this to you, LGTM |
|
❌ Gradle check result for b2cf752: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
ReindexBasicTests.testMultipleSources #13913 |
shwetathareja
left a comment
shwetathareja
left a comment
There was a problem hiding this comment.
Thanks @kkewwei , minor comment otherwise looks good.
|
@shwetathareja please see again. |
|
❌ Gradle check result for b2cf752: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
@kkewwei please fix the conflict in ChangeLog.md |
|
❌ Gradle check result for b2cf752: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: kkewwei <[email protected]>
Signed-off-by: kkewwei <[email protected]> (cherry picked from commit 761e207) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…#14474) (cherry picked from commit 761e207) Signed-off-by: kkewwei <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…rch-project#14155) Signed-off-by: kkewwei <[email protected]>
…rch-project#14155) (opensearch-project#14474) (cherry picked from commit 761e207) Signed-off-by: kkewwei <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <[email protected]>
…rch-project#14155) Signed-off-by: kkewwei <[email protected]>
4 participants
Signed-off-by: kkewwei [email protected]
Description
Limit the max value of cluster.max_shards_per_node to avoid int overflow. We can't reach 1_500_000 in the current opensearch struct.
Related Issues
Resolves #13907
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.