[Explore Vis] update new color scheme for heatmap #10755
+199
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-changeset-bot bot
added a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Oct 20, 2025
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #10755 +/- ##
==========================================
+ Coverage 60.54% 60.55% +0.01%
==========================================
Files 4511 4511
Lines 121359 121385 +26
Branches 20266 20269 +3
==========================================
+ Hits 73473 73502 +29
+ Misses 42738 42735 -3
Partials 5148 5148
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Qxisylolo
requested review from
AMoo-Miki,
BionIT,
Flyingliuhub,
LDrago27,
Maosaic,
SuZhou-Joe,
ZilongX,
abbyhu2000,
ananzh,
angle943,
ashwin-pc,
bandinib-amzn,
curq,
huyaboo,
joshuali925,
joshuarrrr,
kavilla,
manasvinibs,
mengweieric,
ruanyl,
sejli,
virajsanghvi,
xinruiba,
zengyan-amazon,
zhongnansu and
zhyuanqi
as code owners
Qxisylolo
requested review from
TackAdam,
d-buckner,
paulstn,
ps48,
raintygao,
ruchidh,
sumukhswamy and
wanglam
as code owners
ruanyl
reviewed
Oct 21, 2025
Comment on lines
45
to
52
| const newSchemeColor = { | ||
| purples: '#A669E2', | ||
| oranges: '#FF4B14', | ||
| yellows: '#ff9900', | ||
| blues: darkMode ? '#006CE0' : '#003B8F', | ||
| greens: darkMode ? '#008559' : '#005237', | ||
| reds: '#EB003B', | ||
| }; |
There was a problem hiding this comment.
I think we should not hardcode color code here, it should be different for different OUI themes.
ruanyl
previously approved these changes
Oct 27, 2025
| return colors; | ||
| } | ||
|
|
||
| export const getScale = (colorSchema: ColorSchemas) => { |
There was a problem hiding this comment.
Suggest to rename this function to be more specific, like getColorRange?
There was a problem hiding this comment.
sure, thanks for the suggestion
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Qxisylolo
force-pushed
the
feat/update_heatmap_schema
branch
from
4a47a2f to
8400725
Compare
ruanyl
previously approved these changes
Oct 28, 2025
Signed-off-by: Qxisylolo <[email protected]>
ruanyl
changed the title
wanglam
reviewed
Oct 30, 2025
| euiPaletteColorBlindColors[3], | ||
| euiPaletteColorBlindColors[9], | ||
| euiPaletteColorBlindColors[5], | ||
| euiPaletteColorBlindColors[1], |
There was a problem hiding this comment.
Is this duplicate color intentional?
There was a problem hiding this comment.
Yes, in the new theme categories, we’ve defined two types of blue: purple blue and regular blue. But euiPaletteColorBlindColors only includes one blue, I duplicated it to cover both cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration