Add by to forwarded headers in reverse proxy #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serialseb
requested changes
Mar 27, 2019
src/OpenRasta.Plugins.ReverseProxy/NetworkInterfaceContributor.cs
Outdated
Show resolved
Hide resolved
src/OpenRasta.Plugins.ReverseProxy/NetworkInterfaceContributor.cs
Outdated
Show resolved
Hide resolved
Member
|
Side note, if you could rebase that'd fix the build errors |
goughlee
force-pushed
the
rp-add-forwarded-by
branch
from
d0df260 to
756d4c3
Compare
Contributor
Author
|
Have simplified this greatly now. It uses server.localIpAddress if it's there, else it uses _machinename. Also added config option to allow manual setting of ByIdentifier at config time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set by identifier to Owin provided server.localIpAddress if available.
Fall back to _machinename if server.localIpAddress is not available.
Added ByIdentifierOverride option to allow setting the ByIdentifier manually at config time.