Skip to content

Conversation

@rrogoda
Copy link
Contributor

@rrogoda rrogoda commented Feb 12, 2025

Develop example content for OpenMFP's local getting started

Changes:

Add dedicated WebComponent for showcase examples

  • Add example for "Definition of an Entity"
  • Add example for "Defining a iframe based Micro Frontend integration"
  • Add example for "Update of browser path when navigating in the Microfrontend's virtualtree"
  • Add example for "Showcasing a Dashboard like page that integrates one or two example Web Components"

Refers to :
#76

@rrogoda rrogoda requested a review from a team as a code owner February 12, 2025 15:06
@CLAassistant
Copy link

CLAassistant commented Feb 24, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ nexus49
✅ rrogoda
✅ lpgarzonr
❌ Rafał Rogoda


Rafał Rogoda seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@nexus49
Copy link
Member

nexus49 commented Feb 26, 2025

Smaller feedback:

  • Center icons with Text
    image

  • Use Code formatting for when "code" is quoted, see: https://sap.github.io/fundamental-styles/?path=/docs/sap-fiori-components-code--docs
    image

  • consistent text formatting, i'd say lets stick to normal text and code blocks. Try to avoid adding more italic or underlined text

  • the yellow buttons are quite bright, maybe experiment with a less bright color like a grey .

  • I've also asked @lpgarzonr to proofread the 4 paragraphs with examples and to align them with our documentation from a wording point of view

@github-actions github-actions bot added the fix label Feb 27, 2025
Copy link
Member

@lpgarzonr lpgarzonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nexus49 nexus49 merged commit 3665e71 into main Feb 28, 2025
8 of 9 checks passed
@nexus49 nexus49 deleted the feat/develop-example-content-for-openmfp-update branch February 28, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants