Skip to content

Ensure weight_windows_file information is read from XML #3587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 2, 2025
Merged

Ensure weight_windows_file information is read from XML #3587

merged 2 commits into from
Oct 2, 2025

Conversation

@yrrepy
Copy link
Contributor

@yrrepy yrrepy commented Oct 1, 2025

Enable Python API to get weight_windows_file from settings/models

Description

Currently the Python API cannot import weight window hdf5 files from existing XML models.
This enables that.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • [n/a] I have added tests that prove my fix is effective or that my feature works (if applicable)

yrrepy and others added 2 commits October 1, 2025 11:00
@yrrepy
weight_windows_file_from_xml_element
2c3ac1b 
Enable Python APY to get weight_windows_file from settings/models
@paulromano
Separate out weight_windows_on
775bbd9
paulromano
paulromano approved these changes Oct 2, 2025
View reviewed changes
Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paulromano paulromano changed the title weight_windows_file_from_xml_element Ensure weight_windows_file information is read from XML Oct 2, 2025
@paulromano paulromano enabled auto-merge (squash) October 2, 2025 16:52
@paulromano paulromano merged commit 91a19cf into openmc-dev:develop Oct 2, 2025
14 checks passed
Grego01-biot pushed a commit to Grego01-biot/openmc that referenced this pull request Oct 27, 2025
@yrrepy @paulromano
Ensure weight_windows_file information is read from XML (openmc-dev#3587
eabedb8 
)

Co-authored-by: Paul Romano <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulromano paulromano paulromano approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yrrepy @paulromano