Skip to content

Conversation

@shimwell
Copy link
Member

@shimwell shimwell commented Sep 26, 2025

This PR adds a filter_type arg to the Statepoint.get_tally function

This is useful for getting mesh tallies when the user just has access to the statepoint.

When the user only has access to the statepoint results and not the python script is it not conveniently pass in the actual filter object to the existing filter argument as one has to reconstruct the mesh filter with the same mesh and filter_id.

I have also added tests for getting tallies using this new filter_type and a few other methods as I could not find a dedicated test for this function.

Fixes # (issue)

Checklist

  • I have performed a self-review of my own code
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@shimwell
Copy link
Member Author

I beileve the CI was failing due to coveralls being down. Worked fine after a rerun 🎉

Copy link
Contributor

@GuySten GuySten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @shimwell.

@GuySten GuySten enabled auto-merge (squash) September 30, 2025 20:12
@GuySten GuySten merged commit feefcc6 into openmc-dev:develop Sep 30, 2025
14 checks passed
Grego01-biot pushed a commit to Grego01-biot/openmc that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants