Optional separation of mesh-material-volume calc from get_homogenized_materials #3581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable material_volumes to directly save to npz the material volumes it calculates. Enable up/down stream, get_homogenized_materials to also tell it to save these results. This is useful to determine what original inventory is being activated a large mesh R2S
paulromano
changed the title
paulromano
approved these changes
Sep 25, 2025
There was a problem hiding this comment.
@yrrepy Good point you've made here. I wasn't crazy about the approach you had though since it makes the material_volumes function impure. I've modified the branch to take the following approach: the get_homogenized_materials function now optionally takes a material_volumes argument, which allows a user to compute it ahead of time or re-use results from a prior calculation. To save now looks like:
vols = mesh.material_volumes(...)
vols.save('myVolumes.npz')
homog_mats = mesh.get_homogenized_materials(model, material_volumes=vols)Let me know if you're cool with this!
|
Good to Go for Perry! |
Grego01-biot
pushed a commit
to Grego01-biot/openmc
that referenced
this pull request
Oct 27, 2025
…_materials (openmc-dev#3581) Co-authored-by: Paul Romano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable mesh material_volumes to directly save to npz the material volumes it calculates.
When using get_homogenized_materials, the normal mesh volumes (pre-homogenization) are buried and not directly accessible, this enables getting them out.
This is useful to determine what original inventory is being activated in a large mesh R2S.
Small change enabling kwargs to material_volumes and an if statement to save this file. Builds on existing functionatlity.
Checklist