Skip to content

Conversation

@JoffreyDorville
Copy link
Contributor

@JoffreyDorville JoffreyDorville commented Sep 24, 2025

Description

The IFP (Iterated Fission Probability) method is used to calculate effective kinetics parameters in OpenMC. An error was discovered in the way the precursor group numbers were stored. With this correction, the precursor group of the neutron initiating the fission is effectively stored (previously it was the precursor group of the neutron created from this fission event).

This modification only impacts the results obtained for the beta effective.

Checklist

  • I have performed a self-review of my own code
  • I have run clang-format (version 15) on any C++ source files (if applicable)
  • I have followed the style guidelines for Python source files (if applicable)
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@GuySten GuySten added the Bugs label Sep 24, 2025
Copy link
Contributor

@paulromano paulromano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @JoffreyDorville!

@paulromano paulromano merged commit 767db7e into openmc-dev:develop Sep 25, 2025
18 of 26 checks passed
Grego01-biot pushed a commit to Grego01-biot/openmc that referenced this pull request Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants