- 
                Notifications
    You must be signed in to change notification settings 
- Fork 578
[Point Detector] Add distribution get_pdf functionality #3550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Open
      
      
            itay-space
  wants to merge
  79
  commits into
  openmc-dev:develop
  
    
      
        
          
  
    
      Choose a base branch
      
     
    
      
        
      
      
        
          
          
        
        
          
            
              
              
              
  
           
        
        
          
            
              
              
           
        
       
     
  
        
          
            
          
            
          
        
       
    
      
from
itay-space:get_pdf
  
      
      
   
  
    
  
  
  
 
  
      
    base: develop
Could not load branches
            
              
  
    Branch not found: {{ refName }}
  
            
                
      Loading
              
            Could not load tags
            
            
              Nothing to show
            
              
  
            
                
      Loading
              
            Are you sure you want to change the base?
            Some commits from the old base branch may be removed from the timeline,
            and old review comments may become outdated.
          
          
  
     Open
                    Changes from 1 commit
      Commits
    
    
            Show all changes
          
          
            79 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      06ae298
              
                Implement get_pdf functionality
              
              
                 78d841e
              
                Update include/openmc/distribution.h
              
              
                itay-space 33a27a9
              
                Update include/openmc/particle_data.h
              
              
                itay-space d968875
              
                Update include/openmc/particle_data.h
              
              
                itay-space 3b896c0
              
                Update src/physics.cpp
              
              
                itay-space c034bff
              
                Update src/physics.cpp
              
              
                itay-space a5d2f4c
              
                Update src/physics.cpp
              
              
                itay-space ca5b44e
              
                Cleaning some code
              
              
                 eed8b1c
              
                Resolving conversations
              
              
                 f2ecdd4
              
                cosmetic fixes
              
              
                GuySten 71d5fa2
              
                Merge branch 'develop' into get_pdf
              
              
                GuySten c3b4d82
              
                simplified code significantly
              
              
                GuySten 78a33cc
              
                Update src/distribution_angle.cpp
              
              
                itay-space 6d70d39
              
                ran clang format
              
              
                GuySten acfd402
              
                fixes
              
              
                GuySten 98ca32e
              
                cosmetics
              
              
                GuySten 26d2a56
              
                using openmc's fatal_error
              
              
                 7abe69c
              
                Use accessors in powerlaw
              
              
                 d183cce
              
                clausing error for different distributions
              
              
                 37b41c4
              
                fixing function signature
              
              
                 007dcf5
              
                Update include/openmc/angle_energy.h
              
              
                Eliezer214 ebebb7a
              
                Update include/openmc/distribution_angle.h
              
              
                Eliezer214 0239c1f
              
                Update include/openmc/secondary_thermal.h
              
              
                Eliezer214 225f837
              
                Update include/openmc/angle_energy.h
              
              
                Eliezer214 fa22e14
              
                Update include/openmc/reaction_product.h
              
              
                Eliezer214 a0678c9
              
                Update src/reaction_product.cpp
              
              
                itay-space e590d82
              
                Update src/thermal.cpp
              
              
                itay-space 1b1134e
              
                Update include/openmc/secondary_thermal.h
              
              
                itay-space 5c348f1
              
                Update src/secondary_uncorrelated.cpp
              
              
                itay-space 203a191
              
                Update src/secondary_thermal.cpp
              
              
                itay-space c4d8aa6
              
                Update include/openmc/secondary_thermal.h
              
              
                itay-space e9b6860
              
                Update src/reaction_product.cpp
              
              
                itay-space ee1f2c5
              
                Apply suggestion from @GuySten
              
              
                itay-space e07e312
              
                Apply suggestion from @GuySten
              
              
                itay-space 1ab0da1
              
                Update src/thermal.cpp
              
              
                itay-space c98566a
              
                Update src/thermal.cpp
              
              
                itay-space de3fc79
              
                Update include/openmc/reaction_product.h
              
              
                itay-space 978bf74
              
                remove gsl-lite
              
              
                GuySten eb8389d
              
                few fixes to signature
              
              
                 220f099
              
                more signature fixes
              
              
                 d9a2b53
              
                more signature fixes
              
              
                 8271e15
              
                ran clang format
              
              
                GuySten d0d8494
              
                Restore PDF calculation block in secondary_kalbach.cpp after accident…
              
              
                 f2418d2
              
                cleaning
              
              
                 9a5d701
              
                remove gsl-lite
              
              
                GuySten 3f91b0d
              
                clean
              
              
                 e1d069c
              
                Update src/secondary_correlated.cpp
              
              
                itay-space f9e4693
              
                Update include/openmc/secondary_thermal.h
              
              
                GuySten b45dcfd
              
                ran clang format
              
              
                GuySten a85365c
              
                Update src/secondary_kalbach.cpp
              
              
                GuySten d782013
              
                returning pdf assuming data in lab
              
              
                 c72bb02
              
                cleaning
              
              
                 3cb6821
              
                remove gsl-lite
              
              
                GuySten 47e96a6
              
                Apply suggestions from code review
              
              
                GuySten f97f4ad
              
                Update secondary_nbody.cpp
              
              
                GuySten 1e4b763
              
                ran clang format
              
              
                GuySten 3bc4698
              
                Update src/secondary_kalbach.cpp
              
              
                itay-space 4e85033
              
                returning pdf
              
              
                 6727a03
              
                Update src/secondary_nbody.cpp
              
              
                itay-space c5a737b
              
                isotropic and no lab yet
              
              
                 186ad34
              
                Update src/distribution_angle.cpp
              
              
                itay-space 108fa52
              
                remove gsl-lite
              
              
                GuySten 0f40022
              
                ran clang format
              
              
                GuySten 4bf8f23
              
                Update include/openmc/distribution_angle.h
              
              
                GuySten ca7cd85
              
                returning pdf in uncorrelated
              
              
                 d7b1621
              
                fix access to get_pdf
              
              
                GuySten 7cb99e8
              
                ran clang format
              
              
                GuySten e2de1c4
              
                cosmetics
              
              
                GuySten d5ea1c0
              
                WIP: trying new approach until reaction_product.cpp
              
              
                GuySten dc87a7f
              
                fix additional signatures
              
              
                GuySten ad86823
              
                wip
              
              
                GuySten 4500491
              
                reverted most of the changes in the new approach
              
              
                GuySten 7a1b5cc
              
                bugfix
              
              
                GuySten ae2a0fb
              
                bugfix
              
              
                GuySten f3aa6dc
              
                bugfix
              
              
                GuySten 52feef7
              
                another fix for mixed elastic
              
              
                GuySten 12d5372
              
                guarantee every AngleEnergy has sample_energy_and_pdf
              
              
                GuySten ff83fc4
              
                fix for decay photons
              
              
                GuySten f859882
              
                replace pdf->evaluate
              
              
                GuySten File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
      
      Oops, something went wrong.
        
    
  
      
      Oops, something went wrong.
        
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Uh oh!
There was an error while loading. Please reload this page.