Skip to content

Fix Random Ray Solver Bug: Detect Multiple Point Sources in Same Subdivided Source Region #3471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Fix Random Ray Solver Bug: Detect Multiple Point Sources in Same Subdivided Source Region #3471

Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1fe4165
Initial plan
Copilot Jun 26, 2025
7c966c3
Implement error detection for multiple point sources in same subdivid…
Copilot Jun 26, 2025
b7c6bd4
Update error message wording to indicate temporary limitation
Copilot Jun 26, 2025
7211442
Update src/random_ray/flat_source_domain.cpp
jtramm Jun 27, 2025
875a0ec
Fix C++ formatting for multi-line string in error message
Copilot Jun 27, 2025
ab0cfba
Add test for multiple point sources error detection in Random Ray Solver
Copilot Jul 10, 2025
e90e6ff
Replace grep-style test with proper pytest that runs OpenMC simulation
Copilot Jul 10, 2025
4ef907b
Add proper test isolation and error handling to random ray multiple p…
Copilot Jul 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/random_ray/flat_source_domain.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1092,6 +1092,12 @@ void FlatSourceDomain::convert_external_sources()
// point_source_map to determine if there are any point source terms
// that should be applied.
SourceRegionKey key {sr, mesh_bin};
auto it = point_source_map_.find(key);
if (it != point_source_map_.end()) {
fatal_error("Multiple point sources detected in the same subdivided "
"source region. This is not supported in the random ray "
"solver.");
}
point_source_map_[key] = es;
} else {
// If we are not using mesh subdivision, we can apply the external
Expand Down