Skip to content

Conversation

@anthonyvdotbe
Copy link
Contributor

@anthonyvdotbe anthonyvdotbe commented Apr 26, 2022

#118 introduced toolchain support. However, due to the hard-coded "java", this doesn't work for non-java executables such as jlink (i.e. #148)

Fixes #148

Copy link

@rcuprak rcuprak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the fix and it corrects the blocking issue #148

@anthonyvdotbe
Copy link
Contributor Author

@abhinayagarwal @jperedadnr will you please review? (mentioning you since you reviewed the original PR as well)

@alerosmile
Copy link

This should probably be added to other places where executable is still in use. Detecting the JDK home for preparePaths() does not work using toolchains.

@anthonyvdotbe
Copy link
Contributor Author

@alerosmile the sole goal of this PR is to fix the regression introduced in #118 If you believe toolchain support is incomplete or should be improved, please file a new issue and/or PR instead.

Copy link

@OmSarabeSolutions OmSarabeSolutions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this change fixes the goal javafx:jlink when using Toolchains.
Tested with java 22, javafx 23.
Can you merge it please ?

@anthonyvdotbe
Copy link
Contributor Author

@jperedadnr @abhinayagarwal @johanvos would you mind merging and releasing a new version to Maven Central please? This is a trivial fix that has been confirmed to work by 2 different people.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

javafx:jlink 0.0.8 runs java.exe and not jlink resulting in Unrecognized option: --output

4 participants