Skip to content

Conversation

@cushon
Copy link
Contributor

@cushon cushon commented Nov 1, 2025

This is a backport of JDK-8337998, which is a follow-up to JDK-8341779.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8337998 needs maintainer approval

Integration blocker

 ⚠️ Dependency #4149 must be integrated first

Issue

  • JDK-8337998: CompletionFailure in getEnclosingType attaching type annotations (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4150/head:pull/4150
$ git checkout pull/4150

Update a local copy of the PR:
$ git checkout pull/4150
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4150/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 4150

View PR using the GUI difftool:
$ git pr show -t 4150

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4150.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 1, 2025

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into pr/4149 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 1, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport c40e6ef3dcb25b8acc156aa4051694322bf7e351 8337998: CompletionFailure in getEnclosingType attaching type annotations Nov 1, 2025
@openjdk
Copy link

openjdk bot commented Nov 1, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport Port of a pull request already in a different code base label Nov 1, 2025
@openjdk
Copy link

openjdk bot commented Nov 1, 2025

⚠️ @cushon This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

@cushon cushon marked this pull request as ready for review November 1, 2025 21:27
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 1, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 1, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant