-
Notifications
You must be signed in to change notification settings - Fork 232
8319876: Reduce memory consumption of VM_ThreadDump::doit #4006
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back elifaslan1! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
|
This backport pull request has now been updated with issue from the original commit. |
phohensee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm. Looks low risk, but I'd run tier2 on a bigger box to be on the safe side.
|
|
|
@elifaslan1 This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a |
This pull request contains a backport of commit 8ec6b8de3bb3d7aeebdcb45d761b18cce3bab75e from the openjdk/jdk repository to JDK 17.
This backport significantly reduces RSS memory usage during ThreadMXBean.dumpAllThreads(boolean, boolean) execution.
This is not a clean backport due to differences between JDK 17 and upstream:
Threading Context: Changed ResourceMark rm(VMThread::vm_thread()) to ResourceMark rm;
• Similar to JDK 21 backport
Minor conflict resolved: _threads = nullptr; → _threads = NULL; to match JDK 17 conventions
GHA tested additionally ran tier1 tests on my local mac and passed.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/4006/head:pull/4006$ git checkout pull/4006Update a local copy of the PR:
$ git checkout pull/4006$ git pull https://git.openjdk.org/jdk17u-dev.git pull/4006/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 4006View PR using the GUI difftool:
$ git pr show -t 4006Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/4006.diff
Using Webrev
Link to Webrev Comment