Skip to content

Conversation

hgqxjj
Copy link
Member

@hgqxjj hgqxjj commented Sep 21, 2025

Please review this change. Thanks!

Description:

Previously the check combined loadavg() failure and threshold comparison in a single condition. When os::loadavg() returned -1, recent_load contained an undefined value but was still logged as if it was a real load average, leading to misleading log output.

Fix:

This change separates the failure case from the combined check:

  • If os::loadavg() returns -1, log "System loadavg not supported" and skip.
  • Only compare recent_load to the threshold when loadavg() succeeds.

Test:

GHA


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8368089: G1: G1PeriodicGCTask::should_start_periodic_gc may use uninitialised value if os::loadavg is unsupported (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/27413/head:pull/27413
$ git checkout pull/27413

Update a local copy of the PR:
$ git checkout pull/27413
$ git pull https://git.openjdk.org/jdk.git pull/27413/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 27413

View PR using the GUI difftool:
$ git pr show -t 27413

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/27413.diff

Using Webrev

Link to Webrev Comment

…tialised value if os::loadavg is unsupported

Refine log message for unsupported os::loadavg in G1 periodic GC
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 21, 2025

👋 Welcome back ghan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 21, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk
Copy link

openjdk bot commented Sep 21, 2025

@hgqxjj The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 21, 2025
@mlbridge
Copy link

mlbridge bot commented Sep 21, 2025

Webrevs

Disable the functionality when os::loadavg() is not supported.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc [email protected] rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants