Skip to content

Conversation

@antonvoznia
Copy link

@antonvoznia antonvoznia commented Oct 24, 2025

Solved a regression. I used original approach as it is in the OpenJDK.

java/nio/file/spi/SetDefaultProvider.java test is passing.


Progress

  • Change must not contain extraneous whitespace

Error

 ⚠️ OCA signatory status must be verified

Issue

  • JDK-8370483: [CRaC] java/nio/file/spi/SetDefaultProvider.java test fails because of incorrect toFile() usage (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/crac.git pull/270/head:pull/270
$ git checkout pull/270

Update a local copy of the PR:
$ git checkout pull/270
$ git pull https://git.openjdk.org/crac.git pull/270/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 270

View PR using the GUI difftool:
$ git pr show -t 270

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/crac/pull/270.diff

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Oct 24, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2025

Hi @antonvoznia, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user antonvoznia" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@antonvoznia
Copy link
Author

/covered

@bridgekeeper bridgekeeper bot added the oca-verify Needs verification of OCA signatory status label Oct 24, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 24, 2025

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

@openjdk
Copy link

openjdk bot commented Oct 24, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@rvansa rvansa changed the title 8370483: [CRaC] java/nio/file/spi/SetDefaultProvider.java test fails because of incorrect toFile() usage in crac 8370483: [CRaC] java/nio/file/spi/SetDefaultProvider.java test fails because of incorrect toFile() usage Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

oca Needs verification of OCA signatory status oca-verify Needs verification of OCA signatory status

Development

Successfully merging this pull request may close these issues.

1 participant