store pattern by key #1766
Draft
store pattern by key #1766
+108
−101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThis change updates how pattern data is handled and referenced throughout the codebase. It renames properties and types related to patterns for clarity, shifts from using raw strings or arrays to structured objects and maps, and updates interfaces, schemas, and logic in both client and server code to use these new conventions. Error handling and privilege checks for patterns are also improved. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant UserSettings
participant Server
participant PrivilegeChecker
Client->>UserSettings: getSelectedPattern()
UserSettings->>UserSettings: Parse and validate pattern JSON
UserSettings-->>Client: Pattern object or undefined
Client->>Server: joinLobby({ patternName })
Server->>PrivilegeChecker: isPatternAllowed(patternName, flares)
PrivilegeChecker-->>Server: PatternResult (allowed/unknown/forbidden)
alt allowed
Server->>Client: Accept and assign patternData
else forbidden
Server->>Client: Reject with error and close connection
else unknown
Server->>Client: Log warning, allow without patternData
end
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (15)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (14)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
evanpelle
force-pushed
the
evan-store-pattern-by-key
branch
from
9dceac1 to
cb4b74b
Compare
evanpelle
force-pushed
the
evan-store-pattern-by-key
branch
from
cb4b74b to
f00e65a
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
scottanderson
requested changes
Aug 9, 2025
| @@ -203,7 +203,7 @@ export const FlagSchema = z | |||
| }, | |||
| { message: "Invalid flag: must be a valid country code or start with !" }, | |||
| ); | |||
| export const RequiredPatternSchema = z | |||
| export const RequiredPatternDataSchema = z | |||
There was a problem hiding this comment.
these renames makes it hard to read the diff
github-project-automation
bot
moved this from Triage
to Development
in OpenFront Release Management
| @@ -47,7 +47,7 @@ import { createRenderer, GameRenderer } from "./graphics/GameRenderer"; | |||
|
|
|||
| export interface LobbyConfig { | |||
| serverConfig: ServerConfig; | |||
| pattern: string | undefined; | |||
| patternName: string | undefined; | |||
There was a problem hiding this comment.
Could you please check to make sure we're aligned on the desired outcome of #1602 ?
The conversion from pattern -> name and back only needs to happen at the localStorage boundary; everywhere else should continue to use the b64 pattern.
scottanderson
added
Premium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Describe the PR.
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
DISCORD_USERNAME