Skip to content

Conversation

@dyudyunov
Copy link
Contributor

@dyudyunov dyudyunov commented May 23, 2022

Rename toggle_warnings to toggle_warning for consistency with setting_warning.

Relates to: openedx/code-annotations#80

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels May 23, 2022
@openedx-webhooks
Copy link

Thanks for the pull request, @dyudyunov! I've created OSPR-6706 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@dyudyunov
Copy link
Contributor Author

@robrap please, review

@codecov
Copy link

codecov bot commented May 23, 2022

Codecov Report

Merging #252 (ebed895) into master (665b2a4) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   97.07%   97.07%           
=======================================
  Files          69       69           
  Lines        4847     4847           
=======================================
  Hits         4705     4705           
  Misses        142      142           
Flag Coverage Δ
unittests 97.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lti_consumer/plugin/compat.py 37.33% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 665b2a4...ebed895. Read the comment docs.

@dyudyunov dyudyunov force-pushed the rename-warnings-to-warning-in-toggle-annotation branch from 732de38 to 2969dd1 Compare May 23, 2022 12:21
from .lti_xblock import LtiConsumerXBlock

__version__ = '4.1.0'
__version__ = '4.2.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Let's not update version (or changelogs) for any PRs with these changes. I don't think it is necessary.
  2. Can you add the following to commit messages:
Rename toggle_warnings to toggle_warning for consistency
with setting_warning.
  1. Can you add that same sentence, as well as a link to the code-annotations PR, to all the PR descriptions?

Thank you.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, got it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to leave changelogs in the Unreleased section if you don't mind

Rename toggle_warnings to toggle_warning for consistency
with setting_warning.
@dyudyunov dyudyunov force-pushed the rename-warnings-to-warning-in-toggle-annotation branch from 2969dd1 to ebed895 Compare May 23, 2022 15:33
@robrap robrap merged commit 8b8f25d into openedx:master May 23, 2022
@openedx-webhooks
Copy link

@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants