-
Notifications
You must be signed in to change notification settings - Fork 93
FC-0001: rename toggle_warnings to toggle_warning #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FC-0001: rename toggle_warnings to toggle_warning #252
Conversation
|
Thanks for the pull request, @dyudyunov! I've created OSPR-6706 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR. Feel free to add as much of the following information to the ticket as you can:
All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here. Please let us know once your PR is ready for our review and all tests are green. |
|
@robrap please, review |
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
=======================================
Coverage 97.07% 97.07%
=======================================
Files 69 69
Lines 4847 4847
=======================================
Hits 4705 4705
Misses 142 142
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
732de38 to
2969dd1
Compare
lti_consumer/__init__.py
Outdated
| from .lti_xblock import LtiConsumerXBlock | ||
|
|
||
| __version__ = '4.1.0' | ||
| __version__ = '4.2.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Let's not update version (or changelogs) for any PRs with these changes. I don't think it is necessary.
- Can you add the following to commit messages:
Rename toggle_warnings to toggle_warning for consistency
with setting_warning.
- Can you add that same sentence, as well as a link to the code-annotations PR, to all the PR descriptions?
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, got it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to leave changelogs in the Unreleased section if you don't mind
Rename toggle_warnings to toggle_warning for consistency with setting_warning.
2969dd1 to
ebed895
Compare
|
@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future. |
Rename toggle_warnings to toggle_warning for consistency with setting_warning.
Relates to: openedx/code-annotations#80