Pull settings from config file, write/import via S3 #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Works in CH and CSV, fails in Ralph right now. Learners in course size markup not respected yet.
Actors are now assigned to courses with a registration date less than the course end date. Their events should all be between their registration date and the course end date. All actors are registered as part of setup.
Small updates to existing events to be more realistic and match what is actually being produced.
Also refactor to remove "known_" prefixes since they're all generated up front now.
Works for local files still, but also allows direct write to (for example) S3, so we don't write gigs of files locally, then have to upload them. Seems to take about 30% longer than just writing locally, but if you include the upload time it saves about 50%.
Given a location and credentials, this can do a direct import from S3 to ClickHouse, which is very fast.
That wasn't used in most cases, and since we now explicitly define the distributions we no longer need it.
bmtcril
force-pushed
the
bmtcril/config_from_file
branch
from
460bf74 to
a70b0fb
Compare
Ian2012
reviewed
Dec 11, 2023
Ian2012
reviewed
Dec 11, 2023
Ian2012
reviewed
Dec 11, 2023
Ian2012
reviewed
Dec 11, 2023
Contributor
Ian2012
left a comment
Ian2012
left a comment
There was a problem hiding this comment.
Overall looks good to me, still pending a testing with s3 and k8s
Contributor
|
@bmtcril To avoid issues with updates on ERB, should we make obligatory to update this repo too whenever a contribution or change is done there? |
Contributor
Author
|
@Ian2012 I don't think we need to block ERB on this project, it's generally ok for it to fall a little behind since it's not a validation tool, just a best approximation load test tool. |
Ian2012
approved these changes
Dec 20, 2023
Contributor
Ian2012
left a comment
Ian2012
left a comment
There was a problem hiding this comment.
Tested locally with s3, CSV, Clickhouse and Ralph backends
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for the massive PR, this has been getting heavy iteration while I've been load testing for the last several weeks. The culmination of this work is a much faster, more reproducible, and more realistic set of data that exercises all of the existing Aspects Instructor Dashboard reports.
The changes fall into a few buckets: