Skip to content

Conversation

@dcoa
Copy link
Contributor

@dcoa dcoa commented Mar 11, 2025

This PR update the dependencies related with the new CSS variables and design tokens implementation for theming the MFEs.

@openedx-webhooks
Copy link

openedx-webhooks commented Mar 11, 2025

Thanks for the pull request, @dcoa!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Mar 11, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Mar 11, 2025
@dcoa dcoa changed the title chore: update dependencies for css compatibility [WIP] chore: update dependencies for css compatibility Mar 11, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Mar 11, 2025
@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from 7bc49fc to 1ec08bb Compare April 1, 2025 05:36
@codecov
Copy link

codecov bot commented Apr 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (45228f8) to head (534d5ff).
Report is 3 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #869   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           2       2           
  Lines           7       7           
======================================
  Misses          7       7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dcoa dcoa changed the title [WIP] chore: update dependencies for css compatibility feat: update dependencies for css compatibility Apr 1, 2025
@dcoa dcoa force-pushed the dcoa/design-tokens-support branch 2 times, most recently from 8d499c0 to 321eebe Compare April 28, 2025 03:02
@dcoa dcoa force-pushed the dcoa/design-tokens-support branch from 321eebe to 534d5ff Compare May 5, 2025 00:27
@brian-smith-tcril brian-smith-tcril merged commit 8f02d24 into openedx:master May 5, 2025
6 checks passed
@github-project-automation github-project-automation bot moved this from Waiting on Author to Done in Contributions May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants