fix: fixed responsiveness issues on mobile view #1133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemaanamir
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2u-main #1133 +/- ##
===========================================
+ Coverage 67.12% 69.25% +2.12%
===========================================
Files 51 72 +21
Lines 864 1210 +346
Branches 177 272 +95
===========================================
+ Hits 580 838 +258
- Misses 274 357 +83
- Partials 10 15 +5 ☔ View full report in Codecov by Sentry. |
AhtishamShahid
approved these changes
Nov 22, 2024
sundasnoreen12
suggested changes
Nov 22, 2024
Comment on lines
+61
to
+65
| <p className={classNames([ | ||
| 'm-0 color-black', | ||
| isMobileView ? 'h5' : 'h4', | ||
| ])} | ||
| > |
Contributor
There was a problem hiding this comment.
use this <p className={classNames('m-0 color-black', {
'h5': isMobileView,
'h4': !isMobileView,
})}>
Comment on lines
+79
to
+83
| <p className={classNames([ | ||
| 'mb-0', | ||
| isMobileView ? 'x-small' : 'small', | ||
| ])} | ||
| > |
Comment on lines
+19
to
+22
| <p className={classNames([ | ||
| 'font-weight-bold text-primary-500 m-0', | ||
| isMobileView ? 'h3' : 'h2', | ||
| ])} |
Contributor
There was a problem hiding this comment.
follow above pattern for classNames and change wherever used
| </p> | ||
| ); | ||
| const UsernameDescription = () => { | ||
| const isMobileView = useWindowSize().width <= breakpoints.small.minWidth; |
sundasnoreen12
approved these changes
Nov 22, 2024
awais-ansari
added a commit
that referenced
this pull request
Jul 10, 2025
* feat: added country disabling feature (#1084) * feat: added country disabling feature * fix: lint errors * test: added test case for disabled countries * refactor: combined test cases * feat: reskin of Profile MFE main page (#1114) * feat: reskin of Profile MFE main page * feat: reskin of Profile MFE main page * test: updated tests according to the changes * fix: added missing name property * test: updated test snapshot * test: added tests for reducers * feat: moved reskin logic behind env variable * test: updated tests * refactor: refactored code according to requested changes * fix: fixed lint errors * refactor: refactored code according to requested changes * refactor: refactored code according to requested changes * feat: fixed reloading issue * fix: fixed responsiveness issues on mobile view (#1133) * fix: fixed reponsiveness issues on mobile view * test: updated tests * refactor: refactored code as requested * test: added not found test case * test: updated test cases * feat: added restricted country functionality * fix: fixed test cases * test: updated snapshot * test: updated test cases * feat: made profile editable (#1212) * feat: readded editable fields to new profile view * feat: made fullname editable and updated design * test: updated test cases * refactor: refactored code based on reviews * feat: made fullname uneditable and added redirect link (#1215) * feat: made fullname uneditable and added redirect link * refactor: refactored code * refactor: refactored code * chore: rebase 2u-main with master (#1225) * fix(deps): update dependency @edx/frontend-platform to v8.3.3 (#1187) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency core-js to v3.41.0 (#1188) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update `@openedx` dependencies to versions that support React 18 (#1189) * chore(deps): update dependency @openedx/frontend-build to v14.4.1 (#1191) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update react-router monorepo to v6.30.0 (#1192) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat: upgrade react to v18 (#1190) * fix(deps): update dependency @edx/frontend-platform to v8.3.4 (#1195) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @edx/frontend-component-footer to v14.4.0 (#1196) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @edx/frontend-component-header to v6.3.0 (#1197) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @edx/frontend-component-footer to v14.6.0 (#1199) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @edx/openedx-atlas to ^0.7.0 (#1200) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @edx/frontend-component-header to v6.4.0 (#1201) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat: import `FooterSlot` from component package instead of slot package (#1198) * chore(deps): update dependency glob to v11.0.2 (#1202) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @edx/frontend-component-footer to v14.7.0 (#1203) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @edx/frontend-component-footer to v14.7.1 (#1204) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency core-js to v3.42.0 (#1205) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @edx/frontend-platform to v8.3.6 (#1207) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update commitlint monorepo to v19.8.1 (#1206) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @edx/frontend-platform to v8.3.7 (#1209) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @edx/frontend-component-footer to v14.7.2 (#1213) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update react-router monorepo to v6.30.1 (#1214) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @edx/frontend-platform to v8.3.9 (#1216) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(deps): update dependency @edx/frontend-component-footer to v14.9.0 (#1217) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * feat!: add design tokens support (#1220) BREAKING CHANGE: Pre-design-tokens theming is no longer supported. Co-authored-by: Diana Olarte <[email protected]> * fix: fixed lint issues --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Brian Smith <[email protected]> Co-authored-by: Hunia Fatima <[email protected]> Co-authored-by: Diana Olarte <[email protected]> Co-authored-by: sundasnoreen12 <[email protected]> * fix: fixed font sizing issue after applying elm theme (#1228) * Revert "fix: fixed font sizing issue after applying elm theme (#1228)" (#1232) This reverts commit a9159f6. --------- Co-authored-by: muhammadadeeltajamul <[email protected]> Co-authored-by: Muhammad Adeel Tajamul <[email protected]> Co-authored-by: Eemaan Amir <[email protected]> Co-authored-by: sundasnoreen12 <[email protected]> Co-authored-by: sundasnoreen12 <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Brian Smith <[email protected]> Co-authored-by: Hunia Fatima <[email protected]> Co-authored-by: Diana Olarte <[email protected]> Co-authored-by: eemaanamir <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: INF-1708
Fixed responsiveness issues on mobile and tablet views.
Laptop View 1440px:
Laptop View 1024px:
Tablet View 768px:
Mobile View 425px:
Mobile View 375px:
Mobile View 320px: