-
Notifications
You must be signed in to change notification settings - Fork 104
feat: support design tokens and paragon 23 #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support design tokens and paragon 23 #433
Conversation
|
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
4af8d91 to
3522eae
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master-design-tokens #433 +/- ##
=====================================================
Coverage 94.98% 94.98%
=====================================================
Files 139 139
Lines 1357 1357
Branches 264 264
=====================================================
Hits 1289 1289
Misses 60 60
Partials 8 8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
3522eae to
7245f74
Compare
|
Sandbox deployment successful 🚀 |
7245f74 to
48b3320
Compare
|
Sandbox deployment successful 🚀 |
48b3320 to
79cfd61
Compare
|
Sandbox deployment failed 💥 |
|
Sandbox deployment successful 🚀 |
79cfd61 to
b492a0c
Compare
|
Sandbox deployment successful 🚀 |
brian-smith-tcril
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Perfect 🎉
2f5eea7
into
openedx:master-design-tokens
Warning
This PR should not be merge to
masterdirectly, it should point tomaster-design-tokensonce the branch has been created.Description
This PR updates frontend app gradebook to support CSS variables and the corresponding paragon design tokens.
Changes implemented
How to test
Important
This PR requires a compatible version with paragon 23 of dependencies because of that the following PRs need to be merged first: