-
Notifications
You must be signed in to change notification settings - Fork 93
fix: remove primary color from discussion post and messages text #793
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for the pull request, @bydawen! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #793 +/- ##
==========================================
+ Coverage 94.49% 94.56% +0.06%
==========================================
Files 164 164
Lines 3618 3622 +4
Branches 993 991 -2
==========================================
+ Hits 3419 3425 +6
+ Misses 185 183 -2
Partials 14 14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
c5d90df to
844eafe
Compare
|
Sandbox deployment failed 💥 |
|
Sandbox deployment successful 🚀 |
844eafe to
726f9ce
Compare
|
Sandbox deployment successful 🚀 |
726f9ce to
905d58e
Compare
|
Sandbox deployment successful 🚀 |
Description
There is an issue where on discussion pages, comment text and username have
text-primary-500class which is usually used for links, buttons, etc. instead of general text colors of the platform:It's looks strange and not consistent with other platform styles, and can also confuse users by making it appear as if they are clickable elements.
Testing Instructions
After the fix:
Changelog