Skip to content

Conversation

@bydawen
Copy link
Contributor

@bydawen bydawen commented Jul 25, 2025

Description

There is an issue where on discussion pages, comment text and username have text-primary-500 class which is usually used for links, buttons, etc. instead of general text colors of the platform:

Screenshot 2025-07-25 at 19 43 18

It's looks strange and not consistent with other platform styles, and can also confuse users by making it appear as if they are clickable elements.

Testing Instructions

  1. Open course
  2. Go to the Discussion tab
  3. Choose some post and look on it's text
  4. It will look like general text with corresponding color

After the fix:

Screenshot 2025-07-25 at 19 50 35

Changelog

  • Removed wrong text color classes

@openedx-webhooks
Copy link

Thanks for the pull request, @bydawen!

This repository is currently maintained by @openedx/edx-infinity.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 25, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Jul 25, 2025
@bydawen bydawen self-assigned this Jul 25, 2025
@codecov
Copy link

codecov bot commented Jul 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.56%. Comparing base (4d51cf8) to head (905d58e).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #793      +/-   ##
==========================================
+ Coverage   94.49%   94.56%   +0.06%     
==========================================
  Files         164      164              
  Lines        3618     3622       +4     
  Branches      993      991       -2     
==========================================
+ Hits         3419     3425       +6     
+ Misses        185      183       -2     
  Partials       14       14              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mphilbrick211 mphilbrick211 moved this from Needs Triage to In Eng Review in Contributions Jul 28, 2025
@ihor-romaniuk ihor-romaniuk force-pushed the buhaienko/fix/remove-primary-color-from-discussion-post-and-messages-text branch 2 times, most recently from c5d90df to 844eafe Compare August 28, 2025 12:22
@PKulkoRaccoonGang PKulkoRaccoonGang added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Sep 2, 2025
@open-craft-grove
Copy link

Sandbox deployment failed 💥
Please check the settings and requirements.
Retry deployment by pushing a new commit or updating the requirements/settings in the pull request's description.
📜 Failure Logs
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@bydawen bydawen force-pushed the buhaienko/fix/remove-primary-color-from-discussion-post-and-messages-text branch from 844eafe to 726f9ce Compare September 11, 2025 09:39
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@bydawen bydawen force-pushed the buhaienko/fix/remove-primary-color-from-discussion-post-and-messages-text branch from 726f9ce to 905d58e Compare October 15, 2025 10:23
@open-craft-grove
Copy link

Sandbox deployment successful 🚀
🎓 LMS
📝 Studio
ℹ️ Grove Config, Tutor Config, Tutor Requirements

@mphilbrick211 mphilbrick211 moved this from In Eng Review to Ready to Merge in Contributions Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

create-sandbox open-craft-grove should create a sandbox environment from this PR open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready to Merge

Development

Successfully merging this pull request may close these issues.

5 participants