feat: replaced TableContainer with DataTable in enrolledLearnersTable #1518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irfanuddinahmad
force-pushed
the
iahmad/ENT-10466
branch
from
f2deb7c to
79773cc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## eahmadjaved/ENT-10165-2 #1518 +/- ##
===========================================================
+ Coverage 87.23% 87.24% +0.01%
===========================================================
Files 708 710 +2
Lines 16108 16133 +25
Branches 3402 3399 -3
===========================================================
+ Hits 14052 14076 +24
- Misses 1984 1993 +9
+ Partials 72 64 -8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
irfanuddinahmad
force-pushed
the
iahmad/ENT-10466
branch
2 times, most recently
from
ce5dd40 to
05ede13
Compare
irfanuddinahmad
force-pushed
the
iahmad/ENT-10466
branch
from
05ede13 to
9ae143e
Compare
mahamakifdar19
approved these changes
Jun 3, 2025
Contributor
mahamakifdar19
left a comment
mahamakifdar19
left a comment
There was a problem hiding this comment.
LGTM! Please include a screenshot showing the page numbers at the bottom of the table aswell.
irfanuddinahmad
added a commit
that referenced
this pull request
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR replaces the TableContainer with DataTable in the enrolledLearnersTable
JIRA: ENT-10466
Testing outcome:
With TableContainer:
With DataTable:
With updated page handling:
For all changes
Only if submitting a visual change