-
Notifications
You must be signed in to change notification settings - Fork 4
fix: replace FC components with arrow func declaration #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Thanks for the pull request, @tonybusa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
6e017bc to
53f3c43
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #33 +/- ##
=======================================
Coverage 94.32% 94.32%
=======================================
Files 44 44
Lines 881 881
Branches 176 176
=======================================
Hits 831 831
Misses 48 48
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces React.FC (FunctionalComponent) type declarations with standard arrow function declarations across multiple components. The changes improve TypeScript inference and align with modern React best practices by directly typing props in function parameters rather than using the generic FC type.
Key Changes:
- Removed React.FC type annotations from component declarations
- Moved prop type annotations to function parameters
- Removed unused FC imports
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/authz-module/libraries-manager/context.tsx | Refactored LibraryAuthZProvider from React.FC to arrow function with inline prop types |
| src/authz-module/libraries-manager/components/TeamTable/components/SearchFilter.tsx | Converted SearchFilter component and removed unused FC import |
| src/authz-module/libraries-manager/components/TeamTable/components/MultipleChoiceFilter.tsx | Converted MultipleChoiceFilter component and removed unused FC import |
| src/authz-module/libraries-manager/components/ConfirmDeletionModal.tsx | Converted ConfirmDeletionModal component and removed unused FC import |
| src/authz-module/libraries-manager/components/AssignNewRoleModal/AssignNewRoleTrigger.tsx | Converted AssignNewRoleTrigger component and removed unused FC import |
| src/authz-module/libraries-manager/components/AssignNewRoleModal/AssignNewRoleModal.tsx | Converted AssignNewRoleModal component and removed unused FC import |
| src/authz-module/libraries-manager/components/AddNewTeamMemberModal/AddNewTeamMemberTrigger.tsx | Converted AddNewTeamMemberTrigger component and removed unused FC import |
| src/authz-module/libraries-manager/components/AddNewTeamMemberModal/AddNewTeamMemberModal.tsx | Converted AddNewTeamMemberModal component and removed unused FC import |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
diana-villalvazo-wgu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
Fixes the first (Context 1) item listed in: #18
Description
This project sometimes implements React components with
React.FC. This PR checks for that implementation and changes it to use "arrow function declaration". This is discussed on the referenced issue, and also listed in the eslint configuration for frontend-build as Open edX standard. The code changes remove the React import, and makes sure to move the type declaration of the props.Impact
This should not impact any end-user or developer as it will remain "business as usual".
Supporting Information
See discussion here: #18 (comment)
Context 2 on the parent issue will be addressed separately once @dcoa returns.