Skip to content

Conversation

@tonybusa
Copy link

@tonybusa tonybusa commented Nov 5, 2025

Fixes the first (Context 1) item listed in: #18

Description

This project sometimes implements React components with React.FC. This PR checks for that implementation and changes it to use "arrow function declaration". This is discussed on the referenced issue, and also listed in the eslint configuration for frontend-build as Open edX standard. The code changes remove the React import, and makes sure to move the type declaration of the props.

Impact

This should not impact any end-user or developer as it will remain "business as usual".

Supporting Information

See discussion here: #18 (comment)
Context 2 on the parent issue will be addressed separately once @dcoa returns.

@openedx-webhooks
Copy link

openedx-webhooks commented Nov 5, 2025

Thanks for the pull request, @tonybusa!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 5, 2025
@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Nov 5, 2025
@tonybusa tonybusa force-pushed the tony.busa/FC-components branch from 6e017bc to 53f3c43 Compare November 5, 2025 15:37
@codecov
Copy link

codecov bot commented Nov 5, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.32%. Comparing base (a0dc22c) to head (53f3c43).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #33   +/-   ##
=======================================
  Coverage   94.32%   94.32%           
=======================================
  Files          44       44           
  Lines         881      881           
  Branches      176      176           
=======================================
  Hits          831      831           
  Misses         48       48           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tonybusa tonybusa requested a review from Copilot November 5, 2025 16:37
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces React.FC (FunctionalComponent) type declarations with standard arrow function declarations across multiple components. The changes improve TypeScript inference and align with modern React best practices by directly typing props in function parameters rather than using the generic FC type.

Key Changes:

  • Removed React.FC type annotations from component declarations
  • Moved prop type annotations to function parameters
  • Removed unused FC imports

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/authz-module/libraries-manager/context.tsx Refactored LibraryAuthZProvider from React.FC to arrow function with inline prop types
src/authz-module/libraries-manager/components/TeamTable/components/SearchFilter.tsx Converted SearchFilter component and removed unused FC import
src/authz-module/libraries-manager/components/TeamTable/components/MultipleChoiceFilter.tsx Converted MultipleChoiceFilter component and removed unused FC import
src/authz-module/libraries-manager/components/ConfirmDeletionModal.tsx Converted ConfirmDeletionModal component and removed unused FC import
src/authz-module/libraries-manager/components/AssignNewRoleModal/AssignNewRoleTrigger.tsx Converted AssignNewRoleTrigger component and removed unused FC import
src/authz-module/libraries-manager/components/AssignNewRoleModal/AssignNewRoleModal.tsx Converted AssignNewRoleModal component and removed unused FC import
src/authz-module/libraries-manager/components/AddNewTeamMemberModal/AddNewTeamMemberTrigger.tsx Converted AddNewTeamMemberTrigger component and removed unused FC import
src/authz-module/libraries-manager/components/AddNewTeamMemberModal/AddNewTeamMemberModal.tsx Converted AddNewTeamMemberModal component and removed unused FC import

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@tonybusa tonybusa self-assigned this Nov 6, 2025
@tonybusa tonybusa marked this pull request as ready for review November 6, 2025 15:28
Copy link

@diana-villalvazo-wgu diana-villalvazo-wgu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@diana-villalvazo-wgu diana-villalvazo-wgu added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Nov 6, 2025
@diana-villalvazo-wgu diana-villalvazo-wgu moved this from Needs Triage to Ready for Review in Contributions Nov 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

5 participants