Skip to content

Conversation

@dyudyunov
Copy link
Contributor

@dyudyunov dyudyunov commented May 23, 2022

Rename toggle_warnings to toggle_warning for consistency with setting_warning.

Relates to: openedx/code-annotations#80

@openedx-webhooks
Copy link

Thanks for the pull request, @dyudyunov! I've created OSPR-6703 to keep track of it in JIRA, where we prioritize reviews. Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@openedx-webhooks openedx-webhooks added needs triage open-source-contribution PR author is not from Axim or 2U labels May 23, 2022
@dyudyunov
Copy link
Contributor Author

@robrap please review

@robrap robrap merged commit b4fecd6 into openedx:master May 24, 2022
@openedx-webhooks
Copy link

@dyudyunov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

jawad-khan pushed a commit that referenced this pull request Jun 14, 2022
Rename toggle_warnings to toggle_warning for consistency with setting_warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged open-source-contribution PR author is not from Axim or 2U

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants