add anchors to each admonition in the report #33
Conversation
| {% if annotation.report_group_id %} | ||
| {% if loop.changed(annotation.report_group_id) %} | ||
|
|
||
| {% if annotation.annotation_token == '.. toggle_name:' %} |
There was a problem hiding this comment.
It's been a while since I've been in here, but I'm not sure this line is necessary? If so, we should not be hard coding the annotation token, since any given configuration may not have this token in it. Is the goal to have an anchor for the first annotation in each group?
There was a problem hiding this comment.
Ah, good point. I was only thinking of my needs here. Yes, that is the goal. I see what you are saying about it not being necessary if we use the loop.changed part. I suppose I wanted to the anchor to be on something recognizable, in this case, the name of the toggle, because I am trying to have bidirectional links between this report and another.
There was a problem hiding this comment.
@bmedx I changed it to be more generic. Can you take another look when you get a chance?
bmedx
left a comment
bmedx
left a comment
There was a problem hiding this comment.
lgtm 👍 assuming you've tried it on a bit data set and it looked ok
estute
force-pushed
the
estute/add-anchors-to-annotation-doc
branch
2 times, most recently
from
5b286b2 to
a85c0df
Compare
estute
force-pushed
the
estute/add-anchors-to-annotation-doc
branch
from
079cb81 to
00d9fda
Compare
Description: This adds anchors to each admonition describing an individual code annotation group. This way, an external report, like the one generated by querying the database for feature toggle state, can link back to the annotation report for the toggles definition.
JIRA: https://openedx.atlassian.net/browse/TE-2875
Merge checklist:
Post merge:
finished.
Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.