Add prefixing of report filename. Change elapsed time to seconds. #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doctoryes
commented
Feb 21, 2019
| click.echo("Search found {} annotations in {}.".format(annotation_count, elapsed)) | ||
| click.echo("Search found {} annotations in {} seconds.".format( | ||
| annotation_count, elapsed.total_seconds() | ||
| )) |
Contributor
Author
There was a problem hiding this comment.
Currently, this output looks like this:
Search found 357 annotations in -1 day, 19:00:12.574411.
This change will make it look like this:
Search found 357 annotations in 29.3801 seconds.
Contributor
There was a problem hiding this comment.
Thanks for this. I have a different fix for it in the big refactor PR, but I'm glad to see it sorted.
bmedx
approved these changes
Feb 21, 2019
| click.echo("Search found {} annotations in {}.".format(annotation_count, elapsed)) | ||
| click.echo("Search found {} annotations in {} seconds.".format( | ||
| annotation_count, elapsed.total_seconds() | ||
| )) |
Contributor
There was a problem hiding this comment.
Thanks for this. I have a different fix for it in the big refactor PR, but I'm glad to see it sorted.
pwnage101
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump version.
Description: Add prefixing of report filename. Change elapsed time to seconds.
JIRA: Link to JIRA ticket
Dependencies: dependencies on other outstanding PRs, issues, etc.
Merge deadline: List merge deadline (if any)
Installation instructions: List any non-trivial installation
instructions.
Testing instructions:
Reviewers:
Merge checklist:
Post merge:
finished.
Author concerns: List any concerns about this PR - inelegant
solutions, hacks, quick-and-dirty implementations, concerns about
migrations, etc.