Remove legacy fields /userNames and /groupNames #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are added only for legacy clients but cause some issues with Tailor, especially because they might be added with a value of `null` instead of an empty array. Fixes #140.
henrjk
reviewed
Oct 18, 2019
| name: jenkins | ||
| namespace: foo-cd | ||
| userNames: | ||
| - system:serviceaccount:foo-cd:jenkins |
Member
There was a problem hiding this comment.
Should there a be or is there already a test where userNames/groupNames are:
- not in the template
- inconsistent with the subjects. This could prove they are ignored I guess
Member
Author
There was a problem hiding this comment.
Regarding "inconsistent with the subjects": That would need an end-to-end test. The test here does actually prove that they are removed - otherwise the golden diff would show it, and the JSON patches would look different.
henrjk
approved these changes
Oct 18, 2019
Member
henrjk
left a comment
henrjk
left a comment
There was a problem hiding this comment.
I added a question but the code looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are added only for legacy clients but cause some issues with
Tailor, especially because they might be added with a value of
nullinstead of an empty array.
Fixes #140.