Migrate to go mod #727
Merged
Migrate to go mod #727
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
The next steps would be to
|
tianon
approved these changes
Oct 14, 2021
This was referenced Oct 15, 2021
Merged
Contributor
Author
|
@opencontainers/runtime-tools-maintainers PTAL |
vbatts
approved these changes
Oct 18, 2021
Member
|
bah! Travis! |
Mostly done by go mod init go mod edit -go=1.16 go mod tidy go mod vendor rm -rf Godeps git add vendor Signed-off-by: Kir Kolyshkin <[email protected]>
This brings in Go 1.17+ build tags. Signed-off-by: Kir Kolyshkin <[email protected]>
Contributor
|
@vbatts LGTM if we just go with this and then I can find a way to pull Travis |
vbatts
approved these changes
Oct 19, 2021
jdolitsky
approved these changes
Oct 19, 2021
tianon
approved these changes
Oct 19, 2021
Contributor
Author
|
@tianon looks like you can merge this now :) |
Member
|
Thanks! |
Closed
Closed
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minimal migration from Godeps to native go modules, making it possible to use recent go versions.
Closes: #716
Closes: #704