generate: Drop devices and mounts #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This one will be ready to go once we update the spec dependency here as runc is making these changes. |
Contributor
|
Could you rebase this PR? Thanks! |
Since opencontainers/runtime-spec#164 (part of the v0.1.1 release [1]), Linux runtimes are required to supply these devices and mounts. Specifying them explicitly in the config should have no effect, and just makes the config longer than it needs to be. [1]: https://github.com/opencontainers/specs/blob/v0.1.1/config-linux.md#default-devices-and-file-systems Signed-off-by: W. Trevor King <[email protected]>
wking
force-pushed
the
drop-runtime-supplied-devices-and-mounts
branch
from
05c3827 to
080ee00
Compare
Contributor
Author
Contributor
|
Thanks. LGTM. |
mrunalp
pushed a commit
that referenced
this pull request
Mar 8, 2016
…unts generate: Drop devices and mounts
fmuyassarov
pushed a commit
to fmuyassarov/runtime-tools
that referenced
this pull request
May 4, 2023
tap: Teach Header to skip the plan when testCount < 1
fmuyassarov
pushed a commit
to fmuyassarov/runtime-tools
that referenced
this pull request
May 4, 2023
tap: Teach Header to skip the plan when testCount < 1
fmuyassarov
pushed a commit
to fmuyassarov/runtime-tools
that referenced
this pull request
May 6, 2023
tap: Teach Header to skip the plan when testCount < 1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cross-posted from mrunalp/ocitools#15.
Most of these are covered by the requirements that landed in
opencontainers/runtime-spec#164, and I don't think the additional mqueue
mount is worth the space between the spec requirements and the
ocitools-generated configs. More details in the commit messages.
There was some discussion in the 2016-01-20 meeting about the
meaning of lists that didn't include default entries, but I think
we're all on the same page that unset values mean “give me the
defaults”. So this should be mergable without waiting for that
discussion to reach consensus.