config.go: make umask a pointer #1058
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otherwise it is not possible to know whether it was specified or it is set to 0. Signed-off-by: Giuseppe Scrivano <[email protected]>
|
@cyphar PTAL |
|
LGTM |
|
LGTM. |
giuseppe
added a commit
to giuseppe/runtime-tools
that referenced
this pull request
Jan 15, 2021
umask is a pointer to an uint32. The error was first present in the runtime-specs Go bindings and it was fixed with: opencontainers/runtime-spec#1058 Signed-off-by: Giuseppe Scrivano <[email protected]>
giuseppe
added a commit
to giuseppe/runtime-tools
that referenced
this pull request
Jan 15, 2021
umask is a pointer to an uint32. The error was first present in the runtime-specs Go bindings and it was fixed with: opencontainers/runtime-spec#1058 Signed-off-by: Giuseppe Scrivano <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
otherwise it is not possible to know whether it was specified or it is
set to 0.
Signed-off-by: Giuseppe Scrivano [email protected]