Skip to content

Conversation

@kolyshkin
Copy link
Contributor

Older criu versions fails to work with userns due to changes in glibc's
rseq. Skip a test if an older criu version is found.

Fixes (well, works around): #3532

@kolyshkin kolyshkin added area/ci backport/1.1-todo A PR in main branch which needs to be backported to release-1.1 labels Jul 27, 2022
@kolyshkin kolyshkin mentioned this pull request Jul 27, 2022
@kolyshkin kolyshkin force-pushed the ci-fix-ce9 branch 2 times, most recently from 5794655 to 2d79c22 Compare July 28, 2022 00:21
Older criu builds fail to work properly on CentOS Stream 9 due to
changes in glibc's rseq.

Skip criu tests if an older criu version is found.

Fixes: opencontainers#3532

Signed-off-by: Kir Kolyshkin <[email protected]>
@kolyshkin kolyshkin requested a review from AkihiroSuda July 28, 2022 01:17
@kolyshkin kolyshkin marked this pull request as ready for review July 28, 2022 01:17
@kolyshkin kolyshkin added backport/1.1-done A PR in main branch which has been backported to release-1.1 and removed backport/1.1-todo A PR in main branch which needs to be backported to release-1.1 labels Jul 28, 2022
@kolyshkin kolyshkin added this to the 1.2.0 milestone Jul 28, 2022
@kolyshkin kolyshkin mentioned this pull request Jul 28, 2022
Copy link
Member

@rata rata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Copy link
Member

@cyphar cyphar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cyphar cyphar merged commit 6f8cb8b into opencontainers:main Jul 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/ci backport/1.1-done A PR in main branch which has been backported to release-1.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants