libcontainer: remove "pausing" state #3360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danishprakash
commented
Jan 29, 2022
| Restore(process *Process, criuOpts *CriuOpts) error | ||
|
|
||
| // If the Container state is RUNNING or CREATED, sets the Container state to PAUSING and pauses | ||
| // If the Container state is RUNNING or CREATED, sets the Container state to PAUSED and pauses |
Contributor
Author
There was a problem hiding this comment.
Although the actual state that Pause internally sets is FROZEN, I hope this should be okay as an externally exposed func doc? cc/ @kolyshkin
Contributor
There was a problem hiding this comment.
Yes, it's "frozen" in cgroup lingo, and "paused" in libcontainer lingo.
Signed-off-by: danishprakash <[email protected]>
danishprakash
force-pushed
the
remove-pausing
branch
from
055d2fd to
7346dda
Compare
Contributor
That issue also says to convert docs to golang style, so we can't close it just yet. Surely this needs to be a separate PR. So, replace |
Contributor
Author
|
Yes, that can be a separate PR of its own. Updated. |
Contributor
|
@thaJeztah PTAL |
thaJeztah
approved these changes
Feb 1, 2022
Member
thaJeztah
left a comment
thaJeztah
left a comment
There was a problem hiding this comment.
LGTM, thanks for contributing!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon running tests via
make test, I encountered flaky failures, I'll look into those and see if they have something to do with my host because I noticed the same behavior onmaintoo.Addresses #3343