Skip to content

Conversation

mtovts
Copy link
Contributor

@mtovts mtovts commented Aug 16, 2021

Closes #475.

@dbanty
Copy link
Collaborator

dbanty commented Aug 16, 2021

And of course the Windows tests are still failing 🤦🏻‍♂️. I was hoping it was a temporary issue since I think it's during install.

You run Windows right? Any chance you can replicate that error?

@mtovts
Copy link
Contributor Author

mtovts commented Aug 16, 2021

And of course the Windows tests are still failing 🤦🏻‍♂️. I was hoping it was a temporary issue since I think it's during install.

You run Windows right? Any chance you can replicate that error?

My Windows is broken now 🌝 Think I'll try make test on Windows passing in couple of weeks. I'd like to add support for a few more cases first.

@dbanty
Copy link
Collaborator

dbanty commented Aug 16, 2021

On a hunch I disabled tests for Python 3.6 and sure enough it works fine on later versions.

So I think that's fine, 3.6 is EOL end of this year anyway.

@dbanty
Copy link
Collaborator

dbanty commented Aug 16, 2021

Implemented a different fix in #477, thanks for putting this up so fast though!

@dbanty dbanty closed this Aug 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Invalid PythonIdentifier used

2 participants