Overlapping highlights prevent adder from appearing

[mwidner]

Using the latest 1.2 branch, when you select a range that already has more than 1 highlight on it and the range is entirely within those highlights, the button to add another annotation does not appear. A quick scan of the code looks like getSelectedRanges() is ignoring this range? If someone can point me in the right direction, I'm happy to try and fix it and send a pull request. Thanks.

[mwidner]

I've managed to fix this on my site with this change:

diff --git a/src/annotator.coffee b/src/annotator.coffee
index e2693c2..871f2bf 100644
--- a/src/annotator.coffee
+++ b/src/annotator.coffee
@@ -573,7 +573,7 @@ class Annotator extends Delegator

     for range in @selectedRanges
       container = range.commonAncestor
-      if $(container).hasClass('annotator-hl')
+      while $(container).hasClass('annotator-hl')
         container = $(container).parents('[class!=annotator-hl]')[0]
       return if this.isAnnotator(container)

I've tested it with 7-8 levels of overlapping annotations without problem. This is on v1.2.9.

[tilgovi]

@mwidner would you like to submit a pull request and we can add a test? I am happy to help.