fix(streaming): push processed_response.new_items (including HandoffCallItem) to event_queue #1703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fCallItem, are pushed to event_queue - Added `event_queue` parameter to `_get_single_step_result_from_response` - Push `processed_response.new_items` to queue in streaming mode - Non-streaming path (`_run_single_turn`) remains unchanged - Fixes loss of HandoffCallItem in streaming scenarios - Add test_stream_events_main_with_handoff test
Wujiaxuan007
force-pushed
the
fix/streaming-step-items
branch
from
bc27593 to
a5138d1
Compare
|
Hi, can you take a look at the CI errors first? It seems most of the jobs are failing now |
Wujiaxuan007
force-pushed
the
fix/streaming-step-items
branch
from
7062a24 to
ca7a854
Compare
|
Hi @seratch, I’ve fixed all the CI issues in this branch. Could you please approve and run the workflows so the checks can pass? |
|
@codex review this PR |
|
Codex Review: Didn't find any major issues. Nice work! About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
RunImpl.stream_step_items_to_queueto properly handle allRunItemtypes, including handoffs and tool calls.Test plan
test_stream_events.py::test_stream_events_main_with_handoffto ensure:HandoffCallItemandHandoffOutputItem) are emitted.Issue number
Fixes #1712
Checks