Skip to content

Conversation

seratch
Copy link
Member

@seratch seratch commented Sep 8, 2025

Summary

Resolves #1661

  • merge run and initial realtime session settings when constructing a session
  • reuse the merged base when recomputing settings so the active voice is preserved on handoffs or agent updates
  • add a regression test that ensures the initial voice and output audio format remain intact when refreshing session settings

Testing

  • make format
  • make lint
  • make mypy (fails: optional dependencies numpy, sqlalchemy, and litellm are not installed in the test environment)
  • make tests (fails: optional dependencies numpy and litellm are not installed in the test environment)

@seratch seratch added bug Something isn't working feature:realtime labels Sep 8, 2025
@seratch seratch changed the title Preserve realtime session voice settings when updating agents fix: #1661 Preserve realtime session voice settings when updating agents Sep 8, 2025
@seratch seratch requested a review from rm-openai September 8, 2025 09:03
@rm-openai rm-openai merged commit 50d0ffe into main Sep 8, 2025
5 checks passed
@rm-openai rm-openai deleted the codex/fix-voice-update-error-in-conversation branch September 8, 2025 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working codex feature:realtime

Projects

None yet

Development

Successfully merging this pull request may close these issues.

error: cannot update a conversation's voice if assistant audio is present bug

2 participants