Updated the default values for two parameters in the ModelSettings class to align with their documented behavior: #1392
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ass to align with their documented behavior:
seratch
requested changes
Aug 11, 2025
- Revert store and include_usage back to None as default values - Update documentation to accurately reflect API-specific behavior: * store: clarify different default behavior between Responses API and Chat Completions API * include_usage: clarify it's only available for Chat Completions API Addresses reviewer feedback from PR openai#1392
seratch
approved these changes
Aug 11, 2025
vcshih
pushed a commit
to veris-ai/openai-agents-python
that referenced
this pull request
Aug 15, 2025
…ass to align with their documented behavior: (openai#1392)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the default values for two parameters in the ModelSettings class to align with their documented behavior