fix(handoff): enforce strict boolean return in _check_handoff_enabled #1377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch ensures `_check_handoff_enabled()` always returns a strict `bool`, regardless of what the agent’s `is_enabled` returns.
### Problem:
Previously, `is_enabled` could return a non-boolean truthy/falsy value (e.g., `None`, `1`, `"yes"`), which could lead to unpredictable behavior in downstream logic, especially in conditionals like:
```python
if await self._check_handoff_enabled(...):
````
### Fix:
Wrapped the result in `bool()`:
```python
if inspect.isawaitable(res):
res = await res
return bool(res)
```
This guarantees boolean output while maintaining backward compatibility.
|
Since the callable for is_enabled is supposed to return a boolean value, I don't think this change is necessary. Thanks for taking the time for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch ensures
_check_handoff_enabled()always returns a strictbool, regardless of what the agent’sis_enabledreturns.Problem:
Previously,
is_enabledcould return a non-boolean truthy/falsy value (e.g.,None,1,"yes"), which could lead to unpredictable behavior in downstream logic, especially in conditionals like:Fix:
Wrapped the result in
bool():This guarantees boolean output while maintaining backward compatibility.