Skip to content

Conversation

@chalin
Copy link
Contributor

@chalin chalin commented Dec 15, 2022

The following diff of the generated site files confirms that the only change resulting from this PR (other than fixes to the docs side-nav), is the added content for the hardware page:

$ (cd public && git diff -bw -I 'm-docsreferencespecification|^\s+' --ignore-blank-lines) | grep ^diff | grep -v \.xml
diff --git a/docs/reference/specification/metrics/semantic_conventions/hardware-metrics/index.html b/docs/reference/specification/metrics/semantic_conventions/hardware-metrics/index.html
$

@chalin chalin requested a review from a team December 15, 2022 23:53
@chalin
Copy link
Contributor Author

chalin commented Dec 15, 2022

/cc @bertysentry

@bertysentry
Copy link
Contributor

Very nice!

@cartermp cartermp merged commit 573cbe4 into open-telemetry:main Dec 16, 2022
@chalin chalin deleted the chalin-im-spec-adj-front-matter-2022-12-15 branch December 16, 2022 01:16
@chalin
Copy link
Contributor Author

chalin commented Dec 16, 2022

  • Note that I'll be submitting a followup change to the spec since front matter (linkTitle) is missing for the new Hardware page.

All, FYI, here's the PR:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Semantic conventions for hardware metrics appears blank

3 participants