Skip to content

Update nodejs.md #2075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2022
Merged

Update nodejs.md #2075

merged 1 commit into from
Dec 5, 2022

Conversation

@richseviora
Copy link
Contributor

There isn't a troubleshooting step and if you're coming in here having followed instructions from elsewhere, it is really easy to miss that the example shows you explicitly how to setup the otel logger.

@richseviora
Update nodejs.md
02a771e 
There isn't a troubleshooting step and if you're coming in here having followed instructions from elsewhere, it is really easy to miss that the example shows you explicitly how to setup the otel logger.
@richseviora richseviora requested review from a team December 3, 2022 23:52
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Dec 3, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: richseviora / name: Rich Seviora (02a771e)

cartermp
cartermp approved these changes Dec 4, 2022
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

svrnm
svrnm approved these changes Dec 5, 2022
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

We had that troubleshooting blog post for Node.JS a long while back, is it worthwhile to link to that for more info or should we copy some more from there into the docs (in a follow up)

@svrnm svrnm merged commit 219f5c4 into open-telemetry:main Dec 5, 2022
@nicholaschoi168 nicholaschoi168 mentioned this pull request May 19, 2024
Open
@snyk-io snyk-io bot mentioned this pull request May 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@svrnm svrnm svrnm approved these changes

@dyladan dyladan dyladan approved these changes

@cartermp cartermp cartermp approved these changes

@pichlermarc pichlermarc pichlermarc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@richseviora @svrnm @dyladan @cartermp @pichlermarc