Skip to content

Conversation

@scottgerring
Copy link
Member

Fixes #
Follow on from #3126

Changes

Please provide a brief description of the changes here.

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@scottgerring scottgerring requested a review from a team as a code owner October 21, 2025 06:06
@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.7%. Comparing base (3b2f751) to head (e7c40bd).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
opentelemetry-otlp/src/retry.rs 62.5% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #3204     +/-   ##
=======================================
- Coverage   80.8%   80.7%   -0.2%     
=======================================
  Files        128     128             
  Lines      23090   23247    +157     
=======================================
+ Hits       18676   18772     +96     
- Misses      4414    4475     +61     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scottgerring scottgerring force-pushed the chore/otlp-retry-postreview-cleanup branch from aaa5214 to 16d0863 Compare October 21, 2025 06:15
@scottgerring
Copy link
Member Author

scottgerring commented Oct 21, 2025

Open for suggestions for where we can put the runtime selection. This strikes me as a broader question about the stabilisation of the runtime mechanism.

https://github.com/scottgerring/opentelemetry-rust/blob/9ba3a06df952d4888009764bebe665281f9e45b7/opentelemetry-otlp/src/exporter/http/mod.rs#L402-L409

match error_type {
RetryErrorType::NonRetryable => {
otel_warn!(name: "OtlpRetry", message = format!("Operation {:?} failed with non-retryable error: {:?}", operation_name, err));
otel_warn!(name: "Export.Failed.NonRetryable", operation = operation_name, error = format!("{:?}", err));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otel_warn!(
                            name: "Export.Failed.NonRetryable",
                            operation = operation_name,
                            message = "OTLP export failed with non-retryable error - telemetry data will be lost"
                        );

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good; removed the error inline from each of these.

_ => {
// Max retries reached
otel_warn!(name: "OtlpRetry", message = format!("Operation {:?} failed after {} attempts: {:?}", operation_name, attempt, err));
otel_warn!(name: "Export.Failed.Exhausted", operation = operation_name, error = format!("{:?}", err), retries = attempt);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otel_warn!(
name: "Export.Retry.Exhausted",
operation = operation_name,
retries = attempt,
message = "OTLP export failed after all retry attempts - telemetry data will be lost"
);

@scottgerring scottgerring force-pushed the chore/otlp-retry-postreview-cleanup branch from 483c4de to e7c40bd Compare October 31, 2025 07:45
@scottgerring
Copy link
Member Author

@cijothomas the build failure split out here has nothing to do with this change:
#3216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants