-
Notifications
You must be signed in to change notification settings - Fork 588
chore: OTLP retry post-review cleanup #3204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: OTLP retry post-review cleanup #3204
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3204 +/- ##
=======================================
- Coverage 80.8% 80.7% -0.2%
=======================================
Files 128 128
Lines 23090 23247 +157
=======================================
+ Hits 18676 18772 +96
- Misses 4414 4475 +61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aaa5214 to
16d0863
Compare
|
Open for suggestions for where we can put the runtime selection. This strikes me as a broader question about the stabilisation of the runtime mechanism. |
opentelemetry-otlp/src/retry.rs
Outdated
| match error_type { | ||
| RetryErrorType::NonRetryable => { | ||
| otel_warn!(name: "OtlpRetry", message = format!("Operation {:?} failed with non-retryable error: {:?}", operation_name, err)); | ||
| otel_warn!(name: "Export.Failed.NonRetryable", operation = operation_name, error = format!("{:?}", err)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otel_warn!(
name: "Export.Failed.NonRetryable",
operation = operation_name,
message = "OTLP export failed with non-retryable error - telemetry data will be lost"
);There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good; removed the error inline from each of these.
opentelemetry-otlp/src/retry.rs
Outdated
| _ => { | ||
| // Max retries reached | ||
| otel_warn!(name: "OtlpRetry", message = format!("Operation {:?} failed after {} attempts: {:?}", operation_name, attempt, err)); | ||
| otel_warn!(name: "Export.Failed.Exhausted", operation = operation_name, error = format!("{:?}", err), retries = attempt); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
otel_warn!(
name: "Export.Retry.Exhausted",
operation = operation_name,
retries = attempt,
message = "OTLP export failed after all retry attempts - telemetry data will be lost"
);
483c4de to
e7c40bd
Compare
|
@cijothomas the build failure split out here has nothing to do with this change: |
Fixes #
Follow on from #3126
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes