Configurable max backoff for GRPC exporter #4333
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Bump. I don't think there is any potential downside to merging this |
Contributor
Author
|
bump: this is super small, ez to review, and fixes a real problem |
tammy-baylis-swi
approved these changes
Jan 7, 2025
Contributor
tammy-baylis-swi
left a comment
tammy-baylis-swi
left a comment
There was a problem hiding this comment.
Lgtm, thanks for the HTTP equivalent links. Please could you resolve the merge conflict?
awoimbee
force-pushed
the
aw/grpc-exporter-configurable-backoff
branch
from
9963542 to
f43c845
Compare
Contributor
Author
|
Sorry I missed the notification, should be good to merge now ! |
Contributor
Author
|
|
|
So, any plans to get it finally merged ? |
Contributor
|
Hi @open-telemetry/python-maintainers please take a look. (I can't do merges) |
tammy-baylis-swi
moved this from Ready for review
to Easy to review / merge / close
in @xrmx's Python PR digest
lzchen
approved these changes
May 12, 2025
github-project-automation
bot
moved this from Easy to review / merge / close
to Done
in @xrmx's Python PR digest
xrmx
reviewed
May 19, 2025
xrmx
added a commit
to xrmx/opentelemetry-python
that referenced
this pull request
May 19, 2025
xrmx
added a commit
that referenced
this pull request
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4331
This makes it so
_create_exp_backoff_generatoris called withself._MAX_RETRY_TIMEOUTinstead of a local var in the grpc exporter. like absolutely everywhere else (HTTP log exporter, HTTP span exporter, ...).Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: