Prometheus Exporter string representation for target_info labels #3659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test_target_info_enabled_by_default contained some dead code due to a wrong list slicling
kornerc
commented
Jan 31, 2024
exporter/opentelemetry-exporter-prometheus/tests/test_prometheus_exporter.py
Outdated
Show resolved
Hide resolved
kornerc
changed the title
kornerc
changed the title
ocelotl
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3676
Labels of the
target_infometric must be exported in a string representation.Furthermore the
test_target_info_enabled_by_defaultcontained some dead code due to a wrong list slicing.python_list[:0]returns always an empty list.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Ran the unit tests.
Does This PR Require a Contrib Repo Change?
Checklist: