Restrict version of protobuf for Jaeger exporter #3502
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Moving this commit to #3498 since both fixes need to be merged in the same PR. |
aabmass
reviewed
Nov 3, 2023
| "Typing :: Typed", | ||
| ] | ||
| dependencies = [ | ||
| "protobuf ~= 3.20.0", |
Member
There was a problem hiding this comment.
This will cause a conflict with packages/applications trying to install newer protobuf 4. Similar to #3074
Contributor
Author
There was a problem hiding this comment.
Yes, but we are out of support for this exporter already. Maybe we should consider removing it from our tests?
ocelotl
added a commit
to ocelotl/opentelemetry-python
that referenced
this pull request
Nov 4, 2023
ocelotl
added a commit
to ocelotl/opentelemetry-python
that referenced
this pull request
Nov 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3501