Skip to content

Fix argument name to logger_provider on set_logger_provider #3476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Fix argument name to logger_provider on set_logger_provider #3476

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
307dbaa
Fix argument name to logger_provider on set_logger_provider
zchee Oct 14, 2023
1bb3d06
Merge branch 'main' into logs/fix-typo
srikanthccv Nov 5, 2023
cfee302
Merge branch 'main' into logs/fix-typo
lzchen Nov 6, 2023
e024ad2
Merge branch 'main' into logs/fix-typo
lzchen Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions opentelemetry-api/src/opentelemetry/_logs/_internal/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,13 +202,13 @@ def set_lp() -> None:
_logger.warning("Overriding of current LoggerProvider is not allowed")


def set_logger_provider(meter_provider: LoggerProvider) -> None:
def set_logger_provider(logger_provider: LoggerProvider) -> None:
"""Sets the current global :class:`~.LoggerProvider` object.

This can only be done once, a warning will be logged if any further attempt
is made.
"""
_set_logger_provider(meter_provider, log=True)
_set_logger_provider(logger_provider, log=True)


def get_logger(
Expand Down