logs: severity_number is non numerical value

[b0lle]

Describe your environment

Describe your environment
Mac OS X
Python 3.9.6

What happened?

attribute severity_numer is a string representation of an enum, but is specified as number.

Steps to Reproduce

Run Getting Started, metrics example.

Expected Result

{
    "body": "Anonymous player is rolling the dice: 5",
    "severity_number": 13,
    "severity_text": "WARNING",
    "attributes": {
        "otelSpanID": "7d0581e1f3f51bea",
        "otelTraceID": "8b346ee9af8718bf73a4318d073cbbb1",
        "otelTraceSampled": true,
        "otelServiceName": "dice-server"
    },
    "dropped_attributes": 0,
    "timestamp": "2023-11-22T17:01:36.027744Z",
    "trace_id": "0x8b346ee9af8718bf73a4318d073cbbb1",
    "span_id": "0x7d0581e1f3f51bea",
    "trace_flags": 1,
    "resource": "BoundedAttributes({'telemetry.sdk.language': 'python', 'telemetry.sdk.name': 'opentelemetry', 'telemetry.sdk.version': '1.21.0', 'service.name': 'dice-server', 'telemetry.auto.version': '0.42b0'}, maxlen=None)"
}

Actual Result

{
    "body": "Anonymous player is rolling the dice: 5",
    "severity_number": "<SeverityNumber.WARN: 13>",
    "severity_text": "WARNING",
    "attributes": {
        "otelSpanID": "7d0581e1f3f51bea",
        "otelTraceID": "8b346ee9af8718bf73a4318d073cbbb1",
        "otelTraceSampled": true,
        "otelServiceName": "dice-server"
    },
    "dropped_attributes": 0,
    "timestamp": "2023-11-22T17:01:36.027744Z",
    "trace_id": "0x8b346ee9af8718bf73a4318d073cbbb1",
    "span_id": "0x7d0581e1f3f51bea",
    "trace_flags": 1,
    "resource": "BoundedAttributes({'telemetry.sdk.language': 'python', 'telemetry.sdk.name': 'opentelemetry', 'telemetry.sdk.version': '1.21.0', 'service.name': 'dice-server', 'telemetry.auto.version': '0.42b0'}, maxlen=None)"
}

Additional context

No response

Would you like to implement a fix?

None

[xrmx]

The resource does not look good either

[b0lle]

sorry, please ignore the resource, it works just fine - the example I postet is copied from another issue.
Lets focus on the severity_number because the current implementation makes it hard in obervability backend to filter for logs higher than a desired level.

[aabmass]

attribute severity_numer is a string representation of an enum

To be clear, I think you are just talking about the console logging exporter which is pretty much unspecified. Would you be willing to send a PR for this @b0lle ?

[b0lle]

Well, one might want to correct the Console Logger - would work. In my case, I wrote a custom exporter, which exports logs to AWS Cloudwatch.
I my opinion a more general approach to solve this issue is by changing the to_json function of the LogRecord model.

I personally expect an integer for severity_number, when its specified to be one ;) The current implementation is:

"severity_number": repr(self.severity_number),

What I expect is

"severity_number": self.severity_number.value,

since its type inherits from enum.

Please correct me, if I am wrong. I would love to contribute.

[lzchen]

@b0lle

"severity_number": self.severity_number.value,

This makes sense to me.