Skip to content

Conversation

nagkumar91
Copy link
Contributor

@nagkumar91 nagkumar91 commented Oct 7, 2025

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A

Does This PR Require a Core Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@nagkumar91 nagkumar91 marked this pull request as ready for review October 8, 2025 17:45
@nagkumar91 nagkumar91 requested a review from a team as a code owner October 8, 2025 17:45
@zhirafovod
Copy link

@wrisa, can you review it and propose the plan to implement in the opentelemetry-util-genai instead?

@wrisa
Copy link
Contributor

wrisa commented Oct 9, 2025

@wrisa, can you review it and propose the plan to implement in the opentelemetry-util-genai instead?

@nagkumar91 we have latest WIP genai utils where all the semantic convention aligned telemetry can be moved.
Please see the proposal here: https://docs.google.com/document/d/1w9TbtKjuRX_wymS8DRSwPA03_VhrGlyx65hHAdNik1E/edit?tab=t.qneb4vabc1wc#heading=h.kh4j6stirken
Here is an example: https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3768/files#diff-ceaf683887146bf95f37a7ebb888621d695e881d6e69059e4c7b3a9bc0120f9bR50

"azure": GenAI.GenAiProviderNameValues.AZURE_AI_OPENAI.value,
"azure_openai": GenAI.GenAiProviderNameValues.AZURE_AI_OPENAI.value,
"azure-ai-openai": GenAI.GenAiProviderNameValues.AZURE_AI_OPENAI.value,
"azure_ai_openai": GenAI.GenAiProviderNameValues.AZURE_AI_OPENAI.value,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

defined twice

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one has - and the other _

@nagkumar91
Copy link
Contributor Author

nagkumar91 commented Oct 13, 2025

@wrisa, can you review it and propose the plan to implement in the opentelemetry-util-genai instead?

@nagkumar91 we have latest WIP genai utils where all the semantic convention aligned telemetry can be moved. Please see the proposal here: https://docs.google.com/document/d/1w9TbtKjuRX_wymS8DRSwPA03_VhrGlyx65hHAdNik1E/edit?tab=t.qneb4vabc1wc#heading=h.kh4j6stirken Here is an example: https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3768/files#diff-ceaf683887146bf95f37a7ebb888621d695e881d6e69059e4c7b3a9bc0120f9bR50
@zhirafovod @wrisa
Is there some sample code I can run to see if the spans/traces I care about are captured?
If its still in design/ideation, can we get this change merged? I can help out with implementing changes once the proposal gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants