Use exec to launch python in otel-instrument for signal handling.
#788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aclemons
requested review from
Aneurysm9,
codeboten,
tsloughter and
tylerbenson
as code owners
|
|
Otherwise, we cannot setup signal handlers in python to do things at shutdown. This now matches how the scripts work for java / node etc: - https://github.com/open-telemetry/opentelemetry-lambda/blob/b004abbc9af28f9a384f7c0c254abcfe578a2a59/java/layer-wrapper/scripts/otel-handler#L12 - https://github.com/open-telemetry/opentelemetry-lambda/blob/b004abbc9af28f9a384f7c0c254abcfe578a2a59/java/layer-wrapper/scripts/otel-proxy-handler#L12 - https://github.com/open-telemetry/opentelemetry-lambda/blob/b004abbc9af28f9a384f7c0c254abcfe578a2a59/java/layer-wrapper/scripts/otel-sqs-handler#L12 - https://github.com/open-telemetry/opentelemetry-lambda/blob/b004abbc9af28f9a384f7c0c254abcfe578a2a59/java/layer-wrapper/scripts/otel-stream-handler#L12 - https://github.com/open-telemetry/opentelemetry-lambda/blob/b004abbc9af28f9a384f7c0c254abcfe578a2a59/nodejs/packages/layer/scripts/otel-handler#L9
tylerbenson
approved these changes
Jul 17, 2023
rapphil
approved these changes
Aug 1, 2023
codeboten
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, we cannot setup signal handlers in python to do things at shutdown.
This now matches how the scripts work for java / node etc:
opentelemetry-lambda/java/layer-wrapper/scripts/otel-handler
Line 12 in b004abb
opentelemetry-lambda/java/layer-wrapper/scripts/otel-proxy-handler
Line 12 in b004abb
opentelemetry-lambda/java/layer-wrapper/scripts/otel-sqs-handler
Line 12 in b004abb
opentelemetry-lambda/java/layer-wrapper/scripts/otel-stream-handler
Line 12 in b004abb
opentelemetry-lambda/nodejs/packages/layer/scripts/otel-handler
Line 9 in b004abb