-
Notifications
You must be signed in to change notification settings - Fork 954
fix: Update import-in-the-middle
#4745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update import-in-the-middle
#4745
Conversation
AbhiPrasad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a test that validates the named hook export so this doesn't regress?
getsentry/sentry-javascript#12009 (comment) was an example of a esbuild config that had troubles with this before.
|
There's an open issue to add bundler tests to ensure bundler issues aren't introduced: Open telemetry depends on a fixed version of |
AbhiPrasad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so as long as the tests in this repo pass and actually test instrumentation
Yeah that seems fair to me, I think waiting for the bundler tests is a good idea!
pichlermarc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Marc Pichler <[email protected]>
trentm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to wait for some bundler tests, but I don't think we have to wait to merge this.
Agreed. |
|
@timfish In the fix you left the import as If there is a reason, beyond keeping changes to a minimum, could you point me to where I could understand more? Thanks! |
|
When I added the named export to iitm, I forgot to update the separate types and this felt like the easiest way to cast the types for now. Once the open iitm types PR has been merged and released I would prefer the import to be: |
* fix: Update `import-in-the-middle` * changelog and lint * lint * changes from code review Co-authored-by: Marc Pichler <[email protected]> --------- Co-authored-by: Marc Pichler <[email protected]>
import-in-the-middlev1.8.0 has a lot of bug fixes.Closes #4547
In one of those PRs I added a named
Hookexport which should work around the default export issue which closes #4691 and closes #4717.Unfortunately when I added the export I forgot to add it to the types so the types need fudging until this PR makes it into a release.